-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): update gradle and cmake #12914
Conversation
Tests:
|
Upgrading to gradle 7 does not appear to be enough to support JDK 16. I get the following gradle error when I attempt to build an app with this PR and JDK 16 (but it builds fine with JDK 15). I ran into this same error when attempting to build a simple non-Titanium app created via Android Studio.
I think we have to wait for Google to release Android Google Plugin version 7 for JDK 16 support. When I updated my non-Titanium app project in Android Studio to use AGP "7.0.0-beta04", it built fine with JDK 16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
@garymathews, can you update the min "java" property in our "package.json" too please? |
FR Passed. |
Prerequisite:
PR #12959 must be merged first. It enables Jenkins to build with JDK 11.
Summary:
7.0.0
gradle
to7.1
kroll-apt
to handle duplication errorUpdatecmake
to3.18.1
TIMOB-28494
TIMOB-28495