Fix Bitcoin Tracker example's Coindesk API URL #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coindesk updated their API and now has a "Min API" and "Data API". The Min API has the most minimum amount of data returned, and since this specific example just looks for the "price of 1 BTC in USD", it seems most reasonable to use.
This PR updates the API URL and expected response JSON payload in the example star file and the tutorial doc.
This PR also updates the example star file to read the image from a Base64 string. PR#1045 changed this functionality originally, stating Starlark now supports this; however, it doesn't appear to be actual Starlark functionality (but rather a custom Pixlet addition) and attempting to use
load("icon.png", icon = "file")as-is yields the following error:I have not updated any of the other references throughout the codebase, only the bitcoin tracker example, to "test the waters". I'm okay to take that piece out of this PR if desired -- but including it allows it to actually render 😅
This should address Issue #663 and Issue #990.