-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cut and legato, move sample trimming related functions to their own page #269
Conversation
Hey! So, we're currently reconsidering the structure of the documentation (preview at https://tidal-doc.pages.dev, source at https://github.com/trespaul/tidal-doc), including the reference section, which I personally am of the opinion should reflect the modules as they are in the Tidal source code. We're following the "Grand Unified Theory of Documentation", so we're keeping guides and reference sections separate. Please take a look at the new site and let us know what you think! Specifically, do you think we should make a guide for sample trimming functions? |
Nice restructuring! |
Since you've already made the page, I'm happy to add it to my fork and tag you for credit, or if you like, you can open a PR on that repo. Regarding the organisation of the functions: there has been some discussion about that; we're talking about it on the Discord, if you'd like to join, or if you don't have a discord account we can discuss on github somewhere. |
Okay, thanks! Checked the discord, and just made a PR in your repo! |
We could also say vice-versa, as the organisation in source isn't necessarily perfect. In the meantime shall we merge this PR? |
Yes, you're right, I meant to say that they should be in sync 😅 |
They're key functions imo, so 👍 from me |
Done, thanks! |
There were a lot of functions that dealt with trimming samples and I felt there was the need to classify them in functions that trim samples in an absolute manner (sustain), functions that trim them relative to their length (begin, end, grain...) and functions that trim them relative to the events of the pattern (cut, legato).
I did that classification and I moved them to their own page. Is there a way I have to link the page so that it appears in the documentation?