Add binary and binaryN

[heerman]

Create patterns from binary, such as binary(5) -> "1 0 1".

"hh".s().struct(binary(5))
// "hh".s().struct("1 0 1")

"hh".s().struct(binaryN(55532, 16))
// "hh".s().struct("1 1 0 1 1 0 0 0 1 1 1 0 1 1 0 0")

From tidal cycles https://userbase.tidalcycles.org/binary.html

Addresses #670

[heerman]

Hey, this is my first contribution to strudel. Loving strudel and the live coding community!

[felixroos]

great stuff thanks :) the test is still failing, you can fix it by running pnpm codeformat

[felixroos]

tests now failing.. you can fix it withm pnpm snapshot i think. also it would be ace if these functions appeared in the docs, maybe here: https://strudel.cc/learn/factories/ (generated from factories.mdx)

[heerman]

also it would be ace if these functions appeared in the docs, maybe here: https://strudel.cc/learn/factories/ (generated from factories.mdx)

@felixroos I'm having trouble getting the example from signal.mjs to show in factories.mdx <JsDoc client:idle name="binaryN" h={0} />. Is there another step I need? Thanks.

[felixroos]

also it would be ace if these functions appeared in the docs, maybe here: https://strudel.cc/learn/factories/ (generated from factories.mdx)

@felixroos I'm having trouble getting the example from signal.mjs to show in factories.mdx <JsDoc client:idle name="binaryN" h={0} />. Is there another step I need? Thanks.

ah yes, if you change the example in the jsdoc, you need to restart the dev server (or run pnpm jsdoc-json) to regenerate the doc metadata

[heerman]

Ok got it @felixroos. I found a silly issue with my @name getting set to a multi-line string. All good now, ready for re-review.

[felixroos]

thanks! this looks good, i only wonder why you've decided against using fmap (similar to #670)?
there's still a formatting error. btw you can run pnpm check to see if your branch has an error, so you don't need to wait for the ci to run the tests

[heerman]

Well I did like the look of your binpatn, but I ran into a small limitation where I wasn't able to pattern the input "decimal".

Maybe that's just crazy? This is why I took a different approach to make it work. Thoughts?

let binpatn = (dec, len) => seq(
  ...dec.toString(2)
    .padStart(len, '0')
    .split('')
    .map(Number)
)
setcpm(144/4)

// patterned `dec` causes an error
d1: binpatn("<7 8 7 9>", 8)  // cannot parse as numeral: "NaN"
  .add(60).note().piano()._pianoroll({ labels: true })

// d1: binaryN("<7 8 7 9>", 8) // works
//   .add(60).note().piano()._pianoroll({ labels: true })

@felixroos