Remove isUserLoggedIn check in TidalApi #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limits the TidalAPI to be only used when the user is authenticated. This prevents its usage with Client Credentials flow where the client is authenticated and capable to make API requests that don't require user authentication.
deaa
approved these changes
Jan 9, 2025
asendra
approved these changes
Jan 9, 2025
| @@ -15,10 +15,7 @@ enum RequestHelper { | |||
| let credentials = try await credentialsProvider.getCredentials() | |||
| let requestBuilder = try await requestBuilder() | |||
There was a problem hiding this comment.
Ultra-minor thing.
let requestBuilder = try await requestBuilder()
This line could be after the token check. No need for it before, so it would be a bit more optimal.
There was a problem hiding this comment.
Yeah good catch, will follow up in another PR for this 👍🏻
There was a problem hiding this comment.
Actually it is before the check because requestURL is used in the error thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
RequestHelperchecks for a few conditions before making requests. One of the check is whether the user is logged in. It throws an error if that's not the case. This limits the TidalAPI to be only used when the user is authenticated.This prevents its usage with Client Credentials auth flow where the client is authenticated and capable to make API requests that don't require user authentication. This PR removes the check of
isUserLoggedIn == true.