Fix redirect uri handling at login #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part ofd this change, the RedirectUri type has been renamed to RedirectData, for clarity.
as we don't submit full urls anymore, we don't need to check for url correctness
They shouldn't pass in the whole Uri, just the query part.
d1f881c to
9dabd29
Compare
paulinaaniola
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses the issue discovered here
While the change is small - we don't grab the url from the backend anymore (it's unsafe and differs from the spec as well), but persist it when passed in from the client, and only look at the query string anymore - this introduces a breaking change, as it changes the signature of
Auth.finalizeLogin.