Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tests failing after the RN bump #64

Merged
merged 5 commits into from
Nov 15, 2024
Merged

fix: fix tests failing after the RN bump #64

merged 5 commits into from
Nov 15, 2024

Conversation

Kotauror
Copy link
Contributor

@Kotauror Kotauror commented Nov 15, 2024

After upgrading to RN v. 0.76.1 the tests started failing.

In the library the tests were failing with the following error:

/react-native-ticketmaster-ignite/node_modules/react-native/Libraries/vendor/emitter/EventEmitter.js: Unexpected token, expected "]" (39:5)

It looks like an issue related to the newest release of RN that will soon be resolved. It's been already reported on the RN repo: facebook/react-native#46355

The fix applied is one recommended in that thread above (direct link).


In the example apps there were issues with the mocks. This MR changes the mocking strategy to work with the new versions.

Screenshot 2024-11-15 at 12 56 59

@Kotauror Kotauror changed the title fix: fix failing library tests fix: fix tests failing after the RN bump Nov 15, 2024
@Kotauror Kotauror merged commit df7e24e into main Nov 15, 2024
5 checks passed
@Kotauror Kotauror deleted the fix-tests-on-ci branch November 21, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants