manager: Reset search filter after moving from SuperUser destination #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
video6165975940582085579.mp4finally |
By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height
tiann
approved these changes
Nov 11, 2024
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Nov 12, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
fukiame
pushed a commit
to TelegramAt25/KernelSU-shukusai
that referenced
this pull request
Nov 14, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Nov 14, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Nov 14, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Nov 14, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Nov 14, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
cat658011
added a commit
to Exynos9611Development/KernelSU
that referenced
this pull request
Nov 15, 2024
* 'main' of https://github.com/tiann/KernelSU: manager: Reset search filter after moving from SuperUser destination (tiann#2204) manager: Fix not refreshing after action button was pressed (tiann#2201)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Nov 16, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Nov 17, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Nov 17, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
kutemeikito
added a commit
to kutemeikito/KernelSU
that referenced
this pull request
Nov 18, 2024
* 'main' of https://github.com/tiann/KernelSU: manager: Reset search filter after moving from SuperUser destination (tiann#2204) manager: Fix not refreshing after action button was pressed (tiann#2201) Signed-off-by: Edwiin Kusuma Jaya <kutemeikito0905@gmail.com>
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Dec 7, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Dec 7, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Dec 7, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Dec 7, 2024
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
aepranata
pushed a commit
to aepranata/KernelSU
that referenced
this pull request
Dec 10, 2024
…iann/KernelSU#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com) Signed-off-by: Aditya Eka Pranata <aepranata@gmail.com>
aepranata
pushed a commit
to aepranata/KernelSU
that referenced
this pull request
Dec 13, 2024
…iann/KernelSU#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com) Signed-off-by: Aditya Eka Pranata <aepranata@gmail.com>
xeunBin
pushed a commit
to xeunBin/KernelSU-Next-4.14
that referenced
this pull request
Jan 19, 2025
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Jan 29, 2025
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Feb 3, 2025
…iann#2204) By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489 original behaviour https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72 changed behaviour Tested-by: backslashxx [118538522+backslashxx@users.noreply.github.com](mailto:118538522+backslashxx@users.noreply.github.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default there's an annoying behaviour for which the manager leaves the search filter after changing destination without even showing the search bar anymore. Fix that and reset the list to the top instead of leaving it at the searched app's height
https://github.com/user-attachments/assets/268672af-ced9-4293-81df-4e1c7ef33489
original behaviour
https://github.com/user-attachments/assets/b9b318cf-273a-4130-b199-712e99f6ed72
changed behaviour
Tested-by: backslashxx 118538522+backslashxx@users.noreply.github.com