Feature/invite after cherry pick pr created #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod from `handle` method
…thod from `handle` method
…ethod from `handle` method
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
🎊 PR Preview 9b13d8b has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-1011.surge.sh 🕐 Build time: 0.017s
🤖 By surge-preview |
|
/cc @Mini256 |
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 80.39% 80.51% +0.11%
==========================================
Files 20 21 +1
Lines 3265 3321 +56
==========================================
+ Hits 2625 2674 +49
- Misses 413 418 +5
- Partials 227 229 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mini256
reviewed
Aug 30, 2022
Mini256
reviewed
Aug 31, 2022
internal/pkg/externalplugins/cherrypicker/cherrypicker_invite_test.go
Outdated
Show resolved
Hide resolved
internal/pkg/externalplugins/cherrypicker/cherrypicker_invite_test.go
Outdated
Show resolved
Hide resolved
internal/pkg/externalplugins/cherrypicker/cherrypicker_invite_test.go
Outdated
Show resolved
Hide resolved
- replace type of `permission` from `string` to `RepoPermissionLevel`.
Mini256
requested changes
Sep 13, 2022
internal/pkg/externalplugins/cherrypicker/cherrypicker_invite.go
Outdated
Show resolved
Hide resolved
|
@Mini256 I updated the documents, please take a look. |
Mini256
approved these changes
Sep 19, 2022
| @@ -166,6 +169,14 @@ func HelpProvider(epa *tiexternalplugins.ConfigAgent) externalplugins.ExternalPl | |||
| WhoCanUse: "Members of the trusted organization for the repo or anyone(depends on the AllowAll configuration).", | |||
| Examples: []string{"/cherrypick release-3.9", "/cherry-pick release-1.15"}, | |||
| }) | |||
| pluginHelp.AddCommand(pluginhelp.Command{ | |||
| Usage: cherryPickInviteExample, | |||
| Description: "Request a collaborator invitation" + | |||
There was a problem hiding this comment.
Suggested change
| Description: "Request a collaborator invitation" + | |
| Description: "Request a collaborator invitation (Only works in cherry-pick pull requests)." + |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 9b13d8b
|
ti-chi-bot
added a commit
that referenced
this pull request
Sep 21, 2022
{"job":{"type":"presubmit","job":"pull-tichi-rerere","buildid":"1572421727613358080","prowjobid":"3f1a3f07-395a-11ed-bc19-8ef6841f76ec","refs":{"org":"ti-community-infra","repo":"tichi","repo_link":"https://github.com/ti-community-infra/tichi","base_ref":"master","base_sha":"10cfcccaa57db0f5f278017d1551dcb4c788a04d","base_link":"https://github.com/ti-community-infra/tichi/commit/10cfcccaa57db0f5f278017d1551dcb4c788a04d","pulls":[{"number":1011,"author":"wuhuizuo","sha":"9b13d8b4c3b9dfb437e7b59c4a435e16a68f159d","title":"Feature/invite after cherry pick pr created","link":"https://github.com/ti-community-infra/tichi/pull/1011","commit_link":"https://github.com/ti-community-infra/tichi/pull/1011/commits/9b13d8b4c3b9dfb437e7b59c4a435e16a68f159d","author_link":"https://github.com/wuhuizuo"}]},"decoration_config":{"utility_images":{"clonerefs":"gcr.io/k8s-prow/clonerefs:v20211229-5ea9b96f66","initupload":"gcr.io/k8s-prow/initupload:v20211229-5ea9b96f66","entrypoint":"gcr.io/k8s-prow/entrypoint:v20211229-5ea9b96f66","sidecar":"gcr.io/k8s-prow/sidecar:v20211229-5ea9b96f66"},"gcs_configuration":{"bucket":"gs://prow-tidb-logs","path_strategy":"explicit"},"gcs_credentials_secret":"gcs-credentials"}},"options":{"retesting-branch":"rerere","retry":3,"require_contexts":{},"timeout":900000000000},"current_retry_times":1,"time":"2022-09-21T03:08:34.707741727Z"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.