Fixes for PHP 8.1 #179
Merged
Fixes for PHP 8.1 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. "?string" is supported from PHP 7.1 on, so we use that as minimum required PHP version. Resolves: thybag#177
In PHP 8.1, the SoapClient properties are private and cannot be accessed anymore. Thus we store them ourselves. Resolves: thybag#178
|
@potofcoffee Not as much as I'd like. I no longer have access to a normal SharePoint install to test anything with, so any changes I make/merge are pretty much blind. For the most part with fixes like this, I'm reliant on external authors like @cweiske, then confirmation from people like yourself that it actually worked. (Tend to be cautions as back when I could test, about half the PR's i got were incompatible with the actual SP API's and didn't work at all) If anyone has access to a SP install i could use to test some stuff again, I'd be interested in being able to give it a bit of a tune up as most of this lib is ~7 years old and a bit all over the place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.