Improved tests and deployment scripts for Tokenholder DAO #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cygnusv
commented
Feb 15, 2022
•
- Adds tests for:
- Full proposal lifecycle for Tokenholder DAO, including proposal phase, voting, queuing into Timelock and execution
- Migration of TokenholderGovernor: in case we want to redeploy the Tokenholder DAO (since contracts are not upgradeable), the DAO can propose migration simply by updating who can propose to the Timelock (only the incumbent Tokenholder should be able to propose the Timelock)
- Support for relying TXs to the Tokenholder DAO, in case we want to use it for example to retrieve tokens/ETH sent to the governor contract, instead that to the Timelock (which should be the one holding assets). See Add a relay mechanism in the governor OpenZeppelin/openzeppelin-contracts#2926
- Updates OpenZeppelin dependencies to version 4.5, recently released, which has some bugfixes in the governance part
- Deployment scripts for the Tokenholder DAO
Also, let's create a more interesting proposal that can later go into execution
Also, a delay of 1 second was producing unexpected behavior. In any case, it didn't have sense :P
As long as the proposal is successful and the timelock delay pass, who cares who executes? Anyway, it was already permissionless if the call did it via the Tokenholder.execute() method, so this only makes this more consistent. It's also cheaper (like 60k cheaper)!!
Recent v4.5 release included improvements for Governor stuff. See https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v4.5.0
This can be used, for example, to recover tokens or ETH sent to the Governor contract. See OpenZeppelin/openzeppelin-contracts#2926
For simplicity, let's add the zero address to executors at constructor time in tests, too
vzotova
previously approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.