Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass More Arguments During CMake Configuration #78

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Pass More Arguments During CMake Configuration #78

merged 5 commits into from
Nov 20, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Nov 20, 2023

It closes #76.

@threeal threeal self-assigned this Nov 20, 2023
@threeal threeal added the feat label Nov 20, 2023
@threeal threeal added this to the Version 2.0.0 milestone Nov 20, 2023
@threeal threeal force-pushed the js-action-more-args branch from 7e82715 to 7dcde4d Compare November 20, 2023 14:39
@threeal
Copy link
Owner Author

threeal commented Nov 20, 2023

The specified-generator-and-compiler-usage is failing because of missing Ninja for configuration. It will later be solved on #80.

@threeal threeal marked this pull request as ready for review November 20, 2023 14:50
@threeal threeal merged commit 025d277 into js-action Nov 20, 2023
@threeal threeal deleted the js-action-more-args branch November 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
feat
Projects
None yet
Milestone
Version 2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@threeal