Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: implement ClippingGroup object #1389

Merged
merged 8 commits into from
Dec 8, 2024
Merged

WebGPURenderer: implement ClippingGroup object #1389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fed8ae8
Update three.js
Methuselah96 Dec 8, 2024
c5777e3
Add ClippingGroup
Methuselah96 Dec 8, 2024
42b322b
Add src
Methuselah96 Dec 8, 2024
54d6a2a
Update patch and delete src
Methuselah96 Dec 8, 2024
d5d5ef2
Update declarations
Methuselah96 Dec 8, 2024
2c68e44
Add examples
Methuselah96 Dec 8, 2024
c5e3c42
Update
Methuselah96 Dec 8, 2024
34c7c6a
Update patch and delete examples
Methuselah96 Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13426,7 +13426,7 @@ index 0d5b70a2..0c147364 100644
init();

diff --git a/examples-testing/examples/webgpu_clipping.ts b/examples-testing/examples/webgpu_clipping.ts
index e57a7e96..cd6362e3 100644
index 3331adc8..17d73367 100644
--- a/examples-testing/examples/webgpu_clipping.ts
+++ b/examples-testing/examples/webgpu_clipping.ts
@@ -1,4 +1,4 @@
Expand All @@ -13449,25 +13449,7 @@ index e57a7e96..cd6362e3 100644

init();

@@ -101,7 +106,7 @@ function init() {

// ***** Clipping setup (renderer): *****
const globalPlanes = [globalPlane];
- const Empty = Object.freeze([]);
+ const Empty: readonly THREE.Plane[] = Object.freeze([]);

renderer.clippingPlanes = Empty; // GUI sets it to globalPlanes
renderer.localClippingEnabled = true;
@@ -120,7 +125,7 @@ function init() {
folderLocal = gui.addFolder('Local Clipping'),
propsLocal = {
get Enabled() {
- return renderer.localClippingEnabled;
+ return renderer.localClippingEnabled!;
},
set Enabled(v) {
renderer.localClippingEnabled = v;
@@ -193,7 +198,7 @@ function onWindowResize() {
@@ -196,7 +201,7 @@ function onWindowResize() {
renderer.setSize(window.innerWidth, window.innerHeight);
}

Expand Down
Loading
Loading