bump snakeyaml to address CVE-2022-38751 #1346
Merged
+38
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereteog
approved these changes
Mar 8, 2023
|
I think we need 2.0, right? https://bitbucket.org/snakeyaml/snakeyaml/issues/561/cve-2022-1471-vulnerability-in#comment-64876314 |
|
As long as we don't use snakeyaml directly, apparently clj-yaml is immune to this CVE by default. I think we just need to check if we use clj-yaml safely. TK also uses it. clj-commons/clj-yaml#83 |
|
Actually, there are 2 vulns:
We might not need the latter due to clj-yaml, but I think 1.33 is a good version to fix the former. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump snakeyaml version to fix a security issue.
See this conversation to confirm we are not vulnerable to CVE-2022-1471.
The only place that CTIA might parse yaml is during trapperkeeper's bootstrap. But we don't use yaml configs and we'd always trust our own configuration anyway.
§ Squashed Commits