added udpServer/Client direct write options, fixed issue with udp non… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lwahlmeier
commented
Oct 3, 2018
- added in DirectWrite support for udp client/server. This allows you to write to a udp socket w/o having to use the selector. Since UDP will just drop packets if you overfill its socket buffer timing and buffering have to be handled by the implementor. This is more for RTC type communication since its more important to reduce delay to socket then guarantee delivery.
- Fixed non-direct write issue in UDPServer, where the server could mixup the settableListeneeablefuture and the buffer its was tied too if more then one write came in on multiple clients for that server.
…-direct writes possibly getting the future and buffer our of sync
jentfoo
reviewed
Oct 3, 2018
|
Resolved the issue you had, also updated versions of threadly and LS. |
jentfoo
reviewed
Oct 3, 2018
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.7-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-bin.zip | |||
There was a problem hiding this comment.
I think you mean 4.10.2 here. If updating gradle you will need to update the build.upload like this as well:
There was a problem hiding this comment.
ok, I will get that done
|
Fixed the gradle wrapper and upload script, take a look and merge it if you are good with it all. |
|
I will release this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.