DelegatingAuroraConnection: Delay connect failures till connection is used #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used This changes DelegatingAuroraConnection so that as long as at least one connection works, failures to connect wont propagate out of the constructor. Instead the invalid connection will appear valid until it is attempted to be used, at which point an exception will be thrown with the original failure as the cause. This is to improve the ability to use the driver and establish new connections while the aurora cluster is partially unhealthy. Without this Hikari (or other pools) may end up fully removing the connections from the pool as they appear to be invalid / unhealthy, and be also unable to replace them with new connections, even though the aurora cluster is partially usable. This does NOT delay errors when starting up the AuroraClusterMonitor, so starting up a service and needing to monitor a cluster that is partially unhealthy still wont work. This is better than lazily establishing the connections because we don't want the connection establish delay to occur at the time of the operation / request (rather have the overhead while the pool is filling / replenishing).
|
This was actually merged, PR was closed on accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
DelegatingAuroraConnectionso that as long as at least one connection works, failures to connect wont propagate out of the constructor.Instead the invalid connection will appear valid until it is attempted to be used, at which point an exception will be thrown with the original failure as the cause.
This is to improve the ability to use the driver and establish new connections while the aurora cluster is partially unhealthy.
Without this Hikari (or other pools) may end up fully removing the connections from the pool as they appear to be invalid / unhealthy, and be also unable to replace them with new connections, even though the aurora cluster is partially usable.
This does NOT delay errors when starting up the
AuroraClusterMonitor, so starting up a service and needing to monitor a cluster that is partially unhealthy still wont work.This is better than lazily establishing the connections because we don't want the connection establish delay to occur at the time of the operation / request (rather have the overhead while the pool is filling / replenishing).