Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for webhook notifications #164

Merged

Conversation

cbhoffman
Copy link
Contributor

This will enable the use of webhook notifications within alerts using the recent SDK release.

Currently, you will receive an error if you set up alert rule notifications that use a custom webhook integration (for example, a Microsoft Teams integration data source) within Terraform.

Any feedback would be appreciated, thank you!

@joaomper-TE @shahid-te @pedro-te @phpinhei-te

Copy link

@shahid-te shahid-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 😄

@joaomper-TE
Copy link
Contributor

@cbhoffman thanks for contributing. FYI the build is failing because of this:

https://github.com/thousandeyes/terraform-provider-thousandeyes?tab=readme-ov-file#maintainers

The docs/ folder should not be changed manually. Instead, if there are changes to the examples, inputs/outputs of any data_source or resource, you need to run go generate locally and commit the resulting changes to the .md files.

@cbhoffman
Copy link
Contributor Author

@cbhoffman thanks for contributing. FYI the build is failing because of this:

https://github.com/thousandeyes/terraform-provider-thousandeyes?tab=readme-ov-file#maintainers

The docs/ folder should not be changed manually. Instead, if there are changes to the examples, inputs/outputs of any data_source or resource, you need to run go generate locally and commit the resulting changes to the .md files.

Ok thanks for letting me know, sorry about that! I'll fix this morning.

@cbhoffman
Copy link
Contributor Author

When possible, can someone approve the workflow please. @joaomper-TE @shahid-te

@joaomper-TE joaomper-TE changed the title Adding support for webhook notifications feat: adding support for webhook notifications Jan 15, 2024
@joaomper-TE joaomper-TE merged commit d74147c into thousandeyes:main Jan 15, 2024
3 checks passed
@joaomper-TE
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants