Add Ruby 3.0 support #1427
Merged
Add Ruby 3.0 support #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5ac679 to
0e660b2
Compare
99f8be5 to
aa58975
Compare
|
The problem now is a Segmentation fault happening at this line: If you want to see the error locally it's necessary to ran the tests like this with Ruby 3.0.0: If you try to run this command 3 time, you will see that the error happens in different tests for ActionController - or even in diferent files. A test can fail in the first try, but pass at the second. I'm not sure the reason yet. To be honest, I never dealt with this kind of error before. In case you would like to see more about the error message: |
|
More information about the problem: https://bugs.ruby-lang.org/issues/17536 It seems there is a fix for that, ruby/ruby#4077, the problem is that it does not have a release for now. |
3720ae0 to
83bca79
Compare
|
@vsppedro This might be one of the only times I've seen a legitimate bug in Ruby 😆 Should we use |
Me too. 😄
I think it's worth a try. I may need to update some dependencies. We will see.
I agree with you. |
ba4b695 to
668032e
Compare
|
I think we can't do that at the moment. This is the error when trying to use ruby-head: I updated the nokogiri gem to the most recent version. It seems to me that we will need to wait for the release of ruby 3.0.1. |
Closed
|
https://www.ruby-lang.org/en/news/2021/04/05/ruby-3-0-1-released/ I'll update this PR ASAP. |
ce22a93 to
b1f93f4
Compare
f26fa82 to
db94462
Compare
db94462 to
0088950
Compare
|
@vsppedro Ok no worries! Thanks for following up. |
|
Some acceptance tests were failing with this error: To fix that was necessary to add the gem After some research, it seems that Ruby 3 no longer includes the rexml gem by default. What do you think, @mcmire? |
|
@vsppedro Hmm interesting. The only issue I have with adding |
|
@vsppedro Okay, so this is a pretty widely reported issue, and I see one such issue exists in Rails: rails/rails#41502. It seems to be coming from |
|
I see. I'll try to remove it. One example of a test that is failing: Error: |
|
Removing webdrivers gem did the job. What do you think, @mcmire? |
mcmire
approved these changes
Apr 10, 2021
| @@ -49,7 +53,7 @@ jobs: | |||
| - uses: actions/cache@v2 | |||
| with: | |||
| path: vendor/bundle | |||
| key: v1-rubygems-local-${{ runner.os }}-${{ matrix.ruby }}-${{ hashFiles(format('gemfiles/{0}.gemfile.lock', matrix.rails_appraisal)) }} | |||
| key: v1-rubygems-local-${{ runner.os }}-${{ matrix.ruby }}-${{ hashFiles(format('gemfiles/{0}.gemfile.lock', matrix.appraisal)) }} | |||
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to enable the use of shoulda-matchers with Ruby 3.0.0.