Add required/optional qual's to belongs_to/has_one #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 3, 2017
|
|
||
| message = | ||
| 'Expected Child to have a belongs_to association called parent ' + | ||
| '(the association should have been defined with `optional: true`, ' + |
| @@ -279,13 +279,92 @@ | |||
| end | |||
| end | |||
|
|
|||
| def belonging_to_parent(options = {}) | |||
| define_model :parent | |||
| context 'given an association with neither :required nor :optional specified' do | |||
| ) | ||
|
|
||
| if diff | ||
| lines << "Diff:" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -6,6 +6,8 @@ | |||
| require "shoulda/matchers/active_record/association_matchers/order_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/through_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/dependent_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/required_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/optional_matcher" | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -6,6 +6,8 @@ | |||
| require "shoulda/matchers/active_record/association_matchers/order_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/through_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/dependent_matcher" | |||
| require "shoulda/matchers/active_record/association_matchers/required_matcher" | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Rails 5 made two changes to `belongs_to` associations: * `required` and `optional` were added as options (which add and remove a presence validation on the association, respectively) * `required` was made the default In addition, a `required` option was also added to `has_one`. These new qualifiers allow us to test these options appropriately. Credit: Shia <rise.shia@gmail.com>
dd37208 to
3af3d9f
Compare
|
@guialbuk Would you mind reviewing this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 made two changes to
belongs_toassociations:requiredandoptionalwere added as options (which add and removea presence validation on the association, respectively)
requiredwas made the defaultIn addition, a
requiredoption was also added tohas_one.These new qualifiers allow us to test these options appropriately.
Credit: Shia rise.shia@gmail.com
Fixes #956, #870, #861.