Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom completions file #331

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Custom completions file #331

merged 2 commits into from
Nov 21, 2018

Conversation

georgebrock
Copy link
Collaborator

This PR adds support for a $HOME/.gitsh_completions file, so that users can add tab completion rules for their custom Git commands and aliases.

Resolves #315

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

houndci-bot
houndci-bot reviewed Nov 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming 
.rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

salbertson added a commit to salbertson/gitsh that referenced this pull request Nov 16, 2018
@salbertson
Update .rubocop.yml
b789c61 
This should help avoid [recent errors](thoughtbot#331 (review)).
@salbertson salbertson mentioned this pull request Nov 16, 2018
Merged
@georgebrock georgebrock force-pushed the custom-completions-file branch from b5fef36 to 71e023f Compare November 16, 2018 15:10
houndci-bot
houndci-bot reviewed Nov 16, 2018
View reviewed changes
spec/support/file_system.rb
@@ -52,7 +52,7 @@ def switch_home_directory(&block)
ENV['HOME'] = path
write_file("#{path}/.inputrc", DEFAULT_READLINE_CONFIG)
write_file("#{path}/.gitconfig", DEFAULT_GIT_CONFIG)
block.call
block.call(path)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance/RedundantBlockCall: Use yield instead of block.call.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rubocop,

https://bugs.ruby-lang.org/issues/14045
https://bugs.ruby-lang.org/issues/14330

spec/support/file_system.rb
@@ -25,7 +25,7 @@ def in_a_temporary_directory(&block)

def with_a_temporary_home_directory(&block)
if ENV['TEMP_HOME']
block.call
block.call(ENV['TEMP_HOME'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance/RedundantBlockCall: Use yield instead of block.call.

houndci-bot
houndci-bot reviewed Nov 16, 2018
View reviewed changes
spec/support/file_system.rb
@@ -52,7 +52,7 @@ def switch_home_directory(&block)
ENV['HOME'] = path
write_file("#{path}/.inputrc", DEFAULT_READLINE_CONFIG)
write_file("#{path}/.gitconfig", DEFAULT_GIT_CONFIG)
block.call
block.call(path)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance/RedundantBlockCall: Use yield instead of block.call.

spec/support/file_system.rb
@@ -25,7 +25,7 @@ def in_a_temporary_directory(&block)

def with_a_temporary_home_directory(&block)
if ENV['TEMP_HOME']
block.call
block.call(ENV['TEMP_HOME'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance/RedundantBlockCall: Use yield instead of block.call.

mike-burns
mike-burns reviewed Nov 16, 2018
View reviewed changes
Copy link
Contributor

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how easy this change is!

spec/support/file_system.rb
@@ -52,7 +52,7 @@ def switch_home_directory(&block)
ENV['HOME'] = path
write_file("#{path}/.inputrc", DEFAULT_READLINE_CONFIG)
write_file("#{path}/.gitconfig", DEFAULT_GIT_CONFIG)
block.call
block.call(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rubocop,

https://bugs.ruby-lang.org/issues/14045
https://bugs.ruby-lang.org/issues/14330

spec/integration/tab_completion_spec.rb
GitshRunner.interactive do |gitsh|
gitsh.type('init')
gitsh.type('commit --allow-empty -m First')
gitsh.type('config --local alias.recho "!echo"')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm picturing this pronounced as Scooby-Doo saying "echo".

@georgebrock georgebrock force-pushed the custom-completions-file branch from ba1ee1a to b068a91 Compare November 21, 2018 21:31
@georgebrock georgebrock merged commit b068a91 into master Nov 21, 2018
@georgebrock georgebrock deleted the custom-completions-file branch November 21, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@mike-burns mike-burns mike-burns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgebrock @mike-burns @houndci-bot