Support tab completion for variables. #304
Conversation
465238a to
a5d6beb
Compare
|
Travis CI is using a very old version of Git (1.8.5.6) which doesn't support the However, the The |
a5d6beb to
02ab91d
Compare
|
|
||
| def old_git_available_config_variables | ||
| git_output('config --list').lines.map do |line| | ||
| line.split('=').first.to_sym |
There was a problem hiding this comment.
This could use line.upto('=').to_sym to avoid scanning the entire line.
There was a problem hiding this comment.
Sadly, that's not what String#upto does (e.g. 'a'.upto('d') produces an enumerator over ['a', 'b', 'c', 'd']). Your version seems more useful though.
I could use split('=', 2).first, that should avoid scanning the whole thing.
There was a problem hiding this comment.
Hmm...given that #split still returns an array in that case, it's unclear whether that's improving things much. The best alternative I could come up with was
line.each_char.take_while { |c| c != "-" }.join
But given that config lines aren't usually very long (I assume), it's probably not a big deal either way.
There was a problem hiding this comment.
I think I'll stick with split.first.
lib/gitsh/git_repository.rb
Outdated
| out, _, status = Open3.capture3(command) | ||
|
|
||
| if status.success? | ||
| out.chomp.lines.map { |line| line.chomp.to_sym } |
There was a problem hiding this comment.
Is the first #chomp redundant given that each line is individually chomped?
There was a problem hiding this comment.
Excellent point.
lib/gitsh/environment.rb
Outdated
| magic_variables.available_variables + | ||
| variables.keys + | ||
| repo.available_config_variables | ||
| ).sort.uniq |
There was a problem hiding this comment.
For the most micro of micro optimizations, you could uniq.sort -- this will cause sort to have a smaller list to work through.
There was a problem hiding this comment.
We'll save so much time over the next 50 years!
This commit introduces a `Gitsh::TabCompletion::VariableCompleter` object. This is completely separate from the NFA-based completion we use for most things, because: - we immediately know we need to use variable completion based on lexical analysis of the input without having to walk through the NFA's states, and - the context in which the variable appears doesn't inform the completions we present the user with. The `Gitsh::TabCompletion::Facade` object gains the responsibility of deciding which type of completion to invoke, based on information from the `Gitsh::TabCompletion::Context` object. To load the config variables, we try to use the `git status --list --name-only` command. However, this command was only introduced in Git 2.6, and versions back to 2.4 are still officially supported by the Git team. If running the command with `--name-only` fails we fall back to parsing the output of `git status --list`. We don't use the backward compatible version everywhere, because the parsing won't be perfect for multi-line config values (`--name-only` was introduced to address this problem).
9b52443 to
33014f7
Compare
This commit introduces a
Gitsh::TabCompletion::VariableCompleterobject. This is completely separate from the NFA-based completion we use for most things, because:we immediately know we need to use variable completion based on lexical analysis of the input without having to walk through the NFA's states, and
the context in which the variable appears doesn't inform the completions we present the user with.
The
Gitsh::TabCompletion::Facadeobject gains the responsibility of deciding which type of completion to invoke, based on information from theGitsh::TabCompletion::Contextobject.