Update UPGRADE_FROM_FACTORY_GIRL.md #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At my OS X Yosemite 10.10.5 the grep commands does not work. I have updated them with the versions working for me.
MikeRogers0
reviewed
Dec 16, 2017
| @@ -35,7 +35,7 @@ to replace all references with the new constant should do the trick. For | |||
| example, on OS X: | |||
|
|
|||
| ```sh | |||
| grep -e FactoryGirl **/*.rake **/*.rb -s -l | xargs sed -i "" "s|FactoryGirl|FactoryBot|" | |||
| grep -rl -e FactoryGirl --include="*.rake" --include="*.rb" . | xargs sed -i "" "s|FactoryGirl|FactoryBot|" | |||
There was a problem hiding this comment.
The include could also be --include=\*.{rb,rake} what do you think?
There was a problem hiding this comment.
This removes the -s flag in the first but not the second command. It should probably stay.
|
On Ubuntu, I also had to remove the first Leaving it in results in |
This was referenced Jun 16, 2018
|
Thanks for this PR! The example we gave was really intended to be an example, not necessarily a perfect solution that would work for everyone. We have had lots of PRs suggesting alternatives (#1070, #1075, #1084, #1095, #1102), but to reduce churn on this file I have decided to close these issues. I appreciate your help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my OS X Yosemite 10.10.5 the grep commands does not work. I have updated them with the versions working for me.