fix validating email in strict mode #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +150,7 @@ module Validations | |||
|
|
|||
| included do | |||
| validates :email, | |||
| email: { strict_mode: true }, | |||
| email: { mode: :strict }, | |||
There was a problem hiding this comment.
Layout/AlignArguments: Align the arguments of a method call if they span more than one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable strict mode in email validation,
mode: :strictshould be used, notstrict_mode: true. Maybe it used to bestrict_mode: truewith an earlier version of theemail_validatorgem?Be that as it is, it seems that the
strict_modeparameter is ignored andloosevalidation is used.Now, with strict mode turned on, emails like foo;@example.com, foo@.example.com or foo@example..com are no longer valid, so I removed the specs. Why were they expected to be valid until now? I'm not an expert in that matter, but they look pretty invalid to me. 😸