Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginate? should return boolean #2296

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

jubilee2
Copy link
Contributor

@jubilee2 jubilee2 commented Dec 6, 2022

fix #2289

@jubilee2 jubilee2 mentioned this pull request Dec 8, 2022
@pablobm
Copy link
Collaborator

pablobm commented Dec 13, 2022

Thank you!

@pablobm pablobm merged commit 05eae82 into thoughtbot:fix-hasmany-pagination Dec 13, 2022
@pablobm
Copy link
Collaborator

pablobm commented Dec 13, 2022

Oh, wait. I thought this was a PR on main 😓 I'll fix it...

@pablobm
Copy link
Collaborator

pablobm commented Dec 13, 2022

@jubilee2 - Next time, please leave this as a suggestion in a PR comment. I was quite confused there! 😅

@jubilee2
Copy link
Contributor Author

I was trying To do that but it says I do not have permission. You can use crash merge this time if want to keep clean commit

@pablobm
Copy link
Collaborator

pablobm commented Dec 13, 2022

@jubilee2 - oh, i didn't realise. Apologies.

@jubilee2 jubilee2 deleted the patch-2 branch November 7, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants