Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nav styles for namespaced resources #2013

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix nav styles for namespaced resources #2013

merged 1 commit into from
Jun 28, 2021

Conversation

n-studio
Copy link
Contributor

@n-studio n-studio commented Jun 27, 2021 •
edited
Loading 

resource_name # => "blog__post"
resource # => "blog/posts"

@nickcharlton
Copy link
Member

Thanks!

Before/After:

Screenshot 2021-06-28 at 16 37 42

@n-studio @nickcharlton
Fix nav styles for namespaced resources
bf8f52f 
This commit sets the navigation item to be highlighted like the others
are (when they're not namespaced).
@nickcharlton nickcharlton force-pushed the fix/highlight-namespaced-resource-type-in-navigation branch from 70f1f98 to bf8f52f Compare June 28, 2021 15:39
@nickcharlton nickcharlton changed the title fix: highlight namespaced resource type in navigation Fix nav styles for namespaced resources Jun 28, 2021
@nickcharlton nickcharlton merged commit 8fb7cee into thoughtbot:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-studio @nickcharlton