Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Form elements must have labels #415

Closed
tysongach opened this issue Jan 17, 2016 · 0 comments
Closed

[Accessibility] Form elements must have labels #415

tysongach opened this issue Jan 17, 2016 · 0 comments
Assignees
@tysongach

Comments

@tysongach
Copy link
Contributor

The search input is missing a label.

I ran the aXe Chrome extension, and it suggests to fix any of the following:

  • aria-label attribute does not exist or is empty
  • aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty or not visible
  • Form element does not have an implicit (wrapped) <label>
  • Element has no title attribute or the title attribute is empty
tysongach pushed a commit that referenced this issue Jan 18, 2016
Add a label for the search input
7d93442 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
tysongach pushed a commit that referenced this issue Jan 18, 2016
Add a label for the search input
40ab876 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
tysongach pushed a commit that referenced this issue Jan 18, 2016
Add a label for the search input
032c7ee 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
@tysongach tysongach mentioned this issue Jan 18, 2016
Merged
tysongach pushed a commit that referenced this issue Jan 18, 2016
Add a label for the search input
ca230b3 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
tysongach pushed a commit that referenced this issue Jan 20, 2016
Add a label for the search input
51a46ea 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
tysongach pushed a commit that referenced this issue Jan 20, 2016
Add a label for the search input
f35ebfb 
- Properly label the input, to improve accessibility, but visually hide it to
  maintain the design, which uses a placeholder to indicate use
- Uses the hide content technique from The Accessibility Project:
  http://a11yproject.com/posts/how-to-hide-content/
- Fixes #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tysongach tysongach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tysongach