Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 8.0 support #2703

Closed
bzq360 opened this issue Nov 8, 2024 · 3 comments · Fixed by #2705
Closed

Rails 8.0 support #2703

bzq360 opened this issue Nov 8, 2024 · 3 comments · Fixed by #2705
Labels
dependencies changes or issues relating to a dependency
Milestone

Comments

@bzq360
Copy link

bzq360 commented Nov 8, 2024

Hi,
Rails 8.0.0 has just been released yesterday (Nov 7th, 2024). I can see the administrate.gemspec has limited the ActiveRecord dependency to below 8.0 in December 2023. So, when I run bundle install with Administrate 1.0.0-beta2 and Rails 8.0, I get a Could not find compatible versions error.

Can I ask when Rails 8.0 will be supported please?

image image
@nickcharlton
Copy link
Member

Thanks for opening this! We can use this issue for tracking incompatibilities, if there are any.

We originally restricted to the current latest version to try and avoid people having a bad time when they upgrade, but it does mean we need to do a bit of work when new major Rails versions are released.

I plan to start on a PR today to open up the dependency restriction, then we can test that out and see what, if anything, breaks. I'd expect it to go out in the next beta release of v1.0.0, as it's big enough to avoid an rc just yet.

@nickcharlton
Copy link
Member

I started on this, and so far we're waiting on rails-i18n support: svenfuchs/rails-i18n#1130

nickcharlton added a commit that referenced this issue Nov 15, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
@nickcharlton nickcharlton added this to the v1.0.0 milestone Nov 19, 2024
@nickcharlton nickcharlton added the dependencies changes or issues relating to a dependency label Nov 19, 2024
nickcharlton added a commit that referenced this issue Nov 19, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
@nickcharlton
Copy link
Member

I've been working on getting CI running now with Rails 8.0 added, which is still ongoing. Aside from CI, Administrate seems to be able to be installed correctly on Rails 8.0, assuming you're using Sprockets.

I've since opened #2709 though, as it doesn't work with Propshaft because Administrate assumes it's there.

Another fun thing that I've noticed: we added the upper Rails constrain on installing between 0.19.0 and 0.20.0, so if you install Administrate on a new Rails 8.0 app, you're going to get version 0.19.0.

nickcharlton added a commit that referenced this issue Nov 21, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
nickcharlton added a commit that referenced this issue Nov 21, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
nickcharlton added a commit that referenced this issue Nov 21, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
nickcharlton added a commit that referenced this issue Nov 21, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
nickcharlton added a commit that referenced this issue Nov 22, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
nickcharlton added a commit that referenced this issue Nov 22, 2024
We needed to:

* Bring over quite a few things from `rails app:update`, which hopefully
  should make future upgrades easier,
* Fix a change to the `enum` `ActiveModel` signature, which changed
  between Rails 6.0 and 7.0,
* Add a version check from 7.0 for `raise_on_missing_callback_actions`,
* Make a few changes to CI (on top of #2712) to adjust the Ruby versions
  we run CI against.

https://rubyonrails.org/2024/11/7/rails-8-no-paas-required

Closes #2703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes or issues relating to a dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants