Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prescription for installing flask-openid with the right setuptools #18504

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Add prescription for installing flask-openid with the right setuptools #18504

merged 1 commit into from
Oct 6, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 22, 2021

What type of PR is this?

Related: pallets-eco/flask-openid#59
Related: pallets-eco/flask-openid#60
Related: apache/airflow#18075

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2021
@fridex fridex force-pushed the flask-openid-setuptools2to3 branch from 5515362 to 2bd7fd3 Compare September 22, 2021 15:27
@sesheta sesheta requested review from goern and pacospace September 22, 2021 15:28
@sesheta
Copy link
Member

sesheta commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sesheta
Copy link
Member

sesheta commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fridex
Copy link
Contributor Author

fridex commented Oct 6, 2021

Merging to have this in, not stalled. Feel free to raise any comments/suggestions if you have any.

@fridex fridex merged commit 8567763 into thoth-station:master Oct 6, 2021
@fridex fridex deleted the flask-openid-setuptools2to3 branch October 6, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goern goern Awaiting requested review from goern

@pacospace pacospace Awaiting requested review from pacospace

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fridex @sesheta