Handle proxy events properly #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Atrue
commented
Feb 9, 2023
•
- fix server-side socket listeners. Fixes Ensure that the server side close event is fired on server shutdown #372
- add off method to remove the listener. Fixes [Typescript] Client.addEventListener and Server.addEventlistener has wrong typing #371
to make sure all the tests have the correct state when called. afterEach do not reset the state after failed tests
The `close` and `error` events are not fired when the server shuts down. The `message` event is the only event handled differently for the server-side socket and WebSocket client, as it's the handler for the message sent from the client to the server so it should have another event type `server::message`. Other events like `close` and `error` are fired and handled at the same time so no reason to have a special event here. Make the `server::message` the only special event for the `on` handlers for the server-side sockets and use the same type of listeners for other types to handle all the events properly
To have consistency with the `on` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.