Add the hasListeners method to client socket. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thoov apologies for the direct ping, but I would love to get this merged :) |
|
@Pringels What's the use case of having these methods? |
|
@Atrue this change simply extends the already existing limited socket.io support, not Native WebSockets. |
Atrue
reviewed
Sep 29, 2021
|
@Pringels Please use yarn to install packages and make sure you don't have any updated lock files. Also, please rebase and fixup this PR to have only 1 commit |
99c14b0 to
86aa6b0
Compare
86aa6b0 to
515167c
Compare
|
@Atrue please take another look. I've also updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #295