Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed trades aren't being cleared #70

Closed
thomotron opened this issue Jun 26, 2022 · 0 comments
Closed

Completed trades aren't being cleared #70

thomotron opened this issue Jun 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@thomotron
Copy link
Owner

Description

Over time the server's list of trades pending notification grows to unrealistic sizes. From local testing this seems to be because trades that are completed and where both sides have been notified aren't cleared from the waiting list.

Steps to reproduce

  1. Trade with another player
  2. Complete the trade
  3. Have both sides receive their item(s)
  4. Restart the server
@thomotron thomotron added the bug Something isn't working label Jun 26, 2022
thomotron added a commit that referenced this issue Dec 8, 2022
@thomotron
Fix trades with no remaining notifications not clearing
db0cd25 
Fixes #70 where trades completed while both parties were online weren't
being cleared and would just pile up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomotron