Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conversion error in convert function #2

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Update conversion error in convert function #2

merged 1 commit into from
Feb 14, 2021

Conversation

gadhagod
Copy link
Contributor

@gadhagod gadhagod commented Feb 10, 2021

Changed the error from AbstractType.convert() a little to be more descriptive. When you have hundreds of objects to convert, it makes life easier for me by raising the error with the value of the object that it failed to convert. For example,
Instead of:

ValueError: failed to convert from str to DATETIME

It would raise:

ValueError: failed to convert 2021-02-10T99:59:00+0800 from str to DATETIME

Now I know exactly what needs to be fixed.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #2 (8ca54fb) into master (f7a059c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          50       50           
  Lines         909      909           
  Branches       45       45           
=======================================
  Hits          862      862           
  Misses         41       41           
  Partials        6        6           
Impacted Files Coverage Δ
typepy/type/_base.py 90.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a059c...8ca54fb. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.49% when pulling 8ca54fb on gadhagod:master into f7a059c on thombashi:master.

@thombashi thombashi merged commit f08890f into thombashi:master Feb 14, 2021
@thombashi
Copy link
Owner

Thank you for your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants