Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #1

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Add support for Python 3.11 #1

merged 5 commits into from
Feb 18, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 14, 2023

Python 3.11 was released on 2022-10-24 🚀

image

Also test Python 3.12-dev and drop Python 3.6, end-of-life since 2021-12-23.

And we can use the builtin caching of actions/setup-python to remove some config: https://github.com/actions/setup-python#caching-packages-dependencies

@coveralls
Copy link

coveralls commented Feb 17, 2023

Coverage Status

Coverage: 85.63%. Remained the same when pulling 7603197 on hugovk:add-3.11 into b162600 on thombashi:master.

Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep Python 3.6 support for a while.
As you mentioned, Python 3.6 is already reached the EOL.
However, some users of my libraries that depend on this package still use Python 3.6
If this package kept Python 3.6 support, such users could also enjoy performance improvement.

@hugovk
Copy link
Contributor Author

hugovk commented Feb 17, 2023

Sure, updated to keep Python 3.6.

GitHub Actions is dropping Python 3.6 too and it isn't available on ubuntu-latest aka ubuntu-22.04, so we'll need to stick with ubuntu-20.04.

@hugovk hugovk changed the title Add support for Python 3.11, drop EOL 3.6 Add support for Python 3.11 Feb 17, 2023
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your pull request.

@thombashi thombashi merged commit e4ea1ec into thombashi:master Feb 18, 2023
@hugovk hugovk deleted the add-3.11 branch February 18, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants