Use Lowercase in some show methods
#1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
commented
Jan 29, 2025
| else | ||
| print(io, "infinite dimension ") | ||
| end | ||
| print(io, " over ", base_ring(A)) | ||
| else | ||
| print(io, "Group algebra of group ") |
There was a problem hiding this comment.
This is independent of this PR, but I was surprised by this show method:
terseprints "Group algebra of dimension 10 over QQ"- non-terse prints "Group algebra of group of order 10 over QQ"
So the "terse" mode is indeed a little bit shorter, but I wonder why even bother in this case to have two different outputs?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
+ Coverage 76.53% 76.57% +0.03%
==========================================
Files 360 360
Lines 113622 113631 +9
==========================================
+ Hits 86961 87011 +50
+ Misses 26661 26620 -41
|
Also tweak how the bases are printed (print basis vector as `[x, y]` instead of `T[x,y]`)
fa3cca3 to
33d7e57
Compare
thofma
reviewed
Jan 30, 2025
|
P.S.: Ignore the nightly failure, it will be fixed in #1728 |
fingolfin
commented
Feb 2, 2025
fingolfin
commented
Feb 2, 2025
Co-authored-by: Max Horn <max@quendi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweak how the bases are printed (print basis vector as
[x, y]instead ofT[x,y])