Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary copy #1586

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: remove unnecessary copy #1586

merged 2 commits into from
Aug 28, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Aug 27, 2024

No description provided.

@thofma thofma enabled auto-merge (rebase) August 27, 2024 22:09
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (c8604b9) to head (47358eb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
+ Coverage   75.72%   75.75%   +0.03%     
==========================================
  Files         358      358              
  Lines      113693   113693              
==========================================
+ Hits        86095    86130      +35     
+ Misses      27598    27563      -35     
Files Coverage Δ
src/NumFieldOrd/NfOrd/FracIdeal.jl 88.43% <100.00%> (ø)

... and 28 files with indirect coverage changes

@thofma thofma disabled auto-merge August 28, 2024 08:15
@thofma thofma merged commit 2f5a9ba into master Aug 28, 2024
17 of 18 checks passed
@thofma thofma deleted the th/nocopy branch August 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant