Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy keyword to basis of fractional ideals #1579

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

thofma
Copy link
Owner

@thofma thofma commented Aug 17, 2024

@thofma thofma enabled auto-merge (squash) August 17, 2024 16:30
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (339e84a) to head (de7aaaa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   75.66%   75.61%   -0.05%     
==========================================
  Files         357      357              
  Lines      113583   113587       +4     
==========================================
- Hits        85941    85894      -47     
- Misses      27642    27693      +51     
Files Coverage Δ
src/HeckeTypes.jl 84.36% <ø> (ø)
src/NumFieldOrd/NfOrd/FracIdeal.jl 87.86% <100.00%> (+0.14%) ⬆️

... and 24 files with indirect coverage changes

@thofma thofma disabled auto-merge August 17, 2024 20:13
@thofma thofma merged commit ffa4484 into master Aug 17, 2024
17 of 18 checks passed
@thofma thofma deleted the th/fracidlbasis branch August 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy option for bases of fractional ideals
1 participant