-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize local fields a bit #1567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
commented
Jul 26, 2024
joschmitt
commented
Jul 26, 2024
Comment on lines
-231
to
+229
isone(a::LocalFieldElem{S, EisensteinLocalField}) where S = iszero(a-1) | ||
isone(a::LocalFieldElem) = isone(data(a)) | ||
function isone(a::LocalFieldElem{S, EisensteinLocalField}) where S | ||
a1 = a - one(parent(a), precision = precision(a)) | ||
return iszero(a1) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was incorrect/non-optimal before:
julia> F, _ = cyclotomic_field(3);
julia> OF = maximal_order(F);
julia> K, toK = completion(F, 2*OF);
julia> precision(K)
64
julia> a = K(2)^100
2^100 + O(2^165)
julia> a += one(K, precision = precision(a))
2^0 + 2^100 + O(2^165)
julia> isone(a)
true
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
- Coverage 75.66% 75.59% -0.08%
==========================================
Files 357 357
Lines 113542 113549 +7
==========================================
- Hits 85915 85840 -75
- Misses 27627 27709 +82
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make some things a bit faster in the local fields.
I had timings where
_p_adic_regulator
was twice as fast as before, but the timings differ largely accross julia sessions.This closes #1537 as far as I am concerned.
Not all changes here are "trivial", so someone should have a look (once the CI is green).