Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore / Making notebooks up-to-date #251

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

joshuacortez
Copy link
Member

This PR makes sure all the notebooks successfully run from top to bottom.

This PR adds the ff changes:

  1. Updates the overview.usecase_ookla.ipynb tutorial notebook to use updated Nov 2023 HDX PH Admin bounds data since the old link doesn’t work anymore.
  2. Removes unused code
    a. Removes warning filters in notebooks: There were no warnings when the notebooks were run without it. This also helps future-proof the notebook so the maintainers and users are aware of warnings that may appear in the future
    b. Removes unused get_geoboundaries function in 12_spatialjoin_highest_intersection.ipynb

@joshuacortez joshuacortez requested a review from butchtm August 13, 2024 23:06
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@butchtm butchtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@butchtm butchtm merged commit caacdd3 into thinkingmachines:master Aug 14, 2024
1 check passed
@joshuacortez joshuacortez deleted the chore/testing_notebooks branch August 14, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants