Fix/repeat announcements not working #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This solves the issue where some screen readers, such as VoiceOver, don't repeat an announcement if the text remains the same. It checks to see if the message is the same as what is currently within the components state, and then if it is the same it appends the string with a non-breaking space. I've seen this solution used a couple of times before for the same problem.
Where should the reviewer start?
What should the reviewer look at?
Trigger New Announcement
buttonWhat gif best describes this PR or how it makes you feel?
Additional comments:
I'm still fairly new to React so please let me know if I am breaking any rules here.
Definition of Done: