Fix: destroy MediumEditor instance on scope $destroy #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @simison I will merge this and make it a new minor version. Also, I will look into other PR and issues, possibly closing some of them. Thanks again for your efforts! |
thijsw
added a commit
that referenced
this pull request
Mar 15, 2016
Fix: destroy MediumEditor instance on scope $destroy
|
Cheers! 👍 Thanks to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, html would be full of Medium editor’s div leftovers.
Fixes #37
Fixes #24
Duplicate of #38 (sorry, I just want to get this forward and there was quite a bit of refactoring in between). Apparently also dupe of #52.
This also doesn't include dist files, I figured better if @thijsw generates them before new version. Lemme know if I should include them.