Private _logOutput conditional compilation when DISABLE_LOGGING #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids error: '_logOutput' was not declared in this scope when DISABLE_LOGGING is defined.
|
Bump. Can we get this merged? |
joscha
approved these changes
Oct 19, 2021
|
Bumping this. Would really like this added in if possible |
|
@thijse should not have any impact on prior usage and thus an easy addition? |
|
Could we get this PR merged and release a new version? |
|
It would be good to get this one merged if possible, as |
|
Yes please merge this, there are currently multiple prs open changing exactly this. |
This was referenced Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids error: '_logOutput' was not declared in this scope when DISABLE_LOGGING is defined.