[6.4.0] Flip --experimental_cc_implementation_deps (bazelbuild#19751)

This allows distributing libraries as source that use `implementation_deps`. Closes bazelbuild#19724. Commit bazelbuild@05787f3 PiperOrigin-RevId: 571105562 Change-Id: I268c5aa0fd83b220aa85dbeb6eef6a07f6b7d3f7 Co-authored-by: Thi Don <t@thi.im>
thii · Oct 10, 2023 · 924bee9 · 924bee9
1 parent 0017fb3
commit 924bee9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
@@ -1108,7 +1108,7 @@ public Label getPropellerOptimizeLabel() {
 
   @Option(
       name = "experimental_cc_implementation_deps",
-      defaultValue = "false",
+      defaultValue = "true",
       documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
       effectTags = {
         OptionEffectTag.LOADING_AND_ANALYSIS,

diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
@@ -2064,7 +2064,7 @@ public void testImplementationDepsConfigurationHostSucceeds() throws Exception {
   }
 
   @Test
-  public void testImplementationDepsFailsWithoutFlag() throws Exception {
+  public void testImplementationDepsSucceedsWithoutFlag() throws Exception {
     if (!analysisMock.isThisBazel()) {
       return;
     }
@@ -2081,9 +2081,9 @@ public void testImplementationDepsFailsWithoutFlag() throws Exception {
         "    srcs = ['implementation_dep.cc'],",
         "    hdrs = ['implementation_dep.h'],",
         ")");
-    reporter.removeHandler(failFastHandler);
-    getConfiguredTarget("//foo:lib");
-    assertContainsEvent("requires --experimental_cc_implementation_deps");
+    assertThat(getConfiguredTarget("//foo:lib")).isNotNull();
+    ;
+    assertDoesNotContainEvent("requires --experimental_cc_implementation_deps");
   }
 
   @Test