SNPbin fix #86
Merged
SNPbin fix #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently the checks failed. Fishing around in the long log: * checking tests ... ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> library(testthat)
> suppressPackageStartupMessages(library(adegenet))
> test_check("adegenet")
Loading required package: parallel
Error in .check_ncores(cores) : 32 simultaneous processes spawned
Calls: test_check ... initialize -> initialize -> .local -> mclapply -> .check_ncores
Execution halted
* checking PDF version of manual ... OK
* DONE
Status: 1 ERROR, 3 NOTEsNote the 32 cores used. This is really bad. We need to limit the number of cores used by default when using |
|
That is frightening. I'll set parallel = FALSE on the genlight constructor and try again. Luckily none of these tests run on CRAN |
This is because of failures in #86
|
Hooray! Things are passing! |
|
=D On Tue, Aug 18, 2015 at 4:48 PM, Zhian N. Kamvar notifications@github.com
|
thibautjombart
added a commit
that referenced
this pull request
Aug 18, 2015
|
Outstanding - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue #83
I have changed the subsetter for both SNPbin and genlight objects.