Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing parenthesis in find.clusters() choose the number of clusters #283

Merged
merged 2 commits into from
May 6, 2020

Conversation

knausb
Copy link
Contributor

@knausb knausb commented May 6, 2020

A user of our website found this. Thanks!

knausb added 2 commits May 5, 2020 18:42
Missing closing parenthesis for choose clusters.
@romunov
Copy link
Collaborator

romunov commented May 6, 2020

Can you merge (squash) your two commits into one?

@zkamvar
Copy link
Collaborator

zkamvar commented May 6, 2020

We can squash it from here, @romunov. Thanks, @knausb!

@zkamvar zkamvar merged commit fd86d6d into thibautjombart:master May 6, 2020
@knausb
Copy link
Contributor Author

knausb commented May 6, 2020

Sorry about that @romunov ! It looked like such a simple PR that I could manage it on GitHub. Looks like I found a way to munge it. Thank you @zkamvar for sorting it out!

@romunov
Copy link
Collaborator

romunov commented May 7, 2020

@knausb it's a learning process. Fixing my own git mistakes takes half of my time. :)

@zkamvar zkamvar mentioned this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants