-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scaleGen example and use Authors@R #273
Conversation
Hi @courtiol, would you mind adding yourself to the Authors field in the DESCRIPTION file with a [ctb] tag? |
@zkamvar I took the opportunity to refresh a bit the DESCRIPTION file, so please double check. |
Thank you! This was something I had been putting off for a while. The only thing I would request from this is to put @thibautjombart first since he was the first author of the package (I've taken over maintenance recently to expedite bug fixes and features). Additionally, I've found his ORCiD from https://f1000research.com/articles/8-139/v1: 0000-0003-2226-8692 |
This should be OK now! |
Looks good to me! Thank you for the contribution :) |
This PR solves 2 old issues:
Fixes #255, a small typo in the doc
Fixes #254, a broken example
For #254 the core idea that was there (comparing different scaling methods) cannot be applied because the function
scaleGen()
does not allow for such a thing. I tried to follow the original spirit as much as possible by comparing scaling in-PCA vs usingscaleGen()
, but it is not particularly insightful so an alternative would be to cut short the example.