Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaleGen example and use Authors@R #273

Merged
merged 6 commits into from
Feb 23, 2020

Conversation

courtiol
Copy link
Contributor

@courtiol courtiol commented Feb 16, 2020

This PR solves 2 old issues:

Fixes #255, a small typo in the doc

Fixes #254, a broken example

For #254 the core idea that was there (comparing different scaling methods) cannot be applied because the function scaleGen() does not allow for such a thing. I tried to follow the original spirit as much as possible by comparing scaling in-PCA vs using scaleGen(), but it is not particularly insightful so an alternative would be to cut short the example.

@zkamvar
Copy link
Collaborator

zkamvar commented Feb 21, 2020

Hi @courtiol, would you mind adding yourself to the Authors field in the DESCRIPTION file with a [ctb] tag?

@courtiol
Copy link
Contributor Author

@zkamvar I took the opportunity to refresh a bit the DESCRIPTION file, so please double check.
I switched the declaration of authorship to the more modern Authors@R syntax.
That implied that I had to fill in the tags which were not present.
I listed all as ctb but you ("cre" + "aut") and @thibautjombart ("aut").
I added your ORCID number but did not bother with the others.
I did try for @thibautjombart but could not make sure of which ORCID number was good as several profile exist and none is public...

@zkamvar
Copy link
Collaborator

zkamvar commented Feb 21, 2020

@zkamvar I took the opportunity to refresh a bit the DESCRIPTION file, so please double check.
I switched the declaration of authorship to the more modern Authors@R syntax.
That implied that I had to fill in the tags which were not present.
I listed all as ctb but you ("cre" + "aut") and @thibautjombart ("aut").
I added your ORCID number but did not bother with the others.
I did try for @thibautjombart but could not make sure of which ORCID number was good as several profile exist and none is public...

Thank you! This was something I had been putting off for a while. The only thing I would request from this is to put @thibautjombart first since he was the first author of the package (I've taken over maintenance recently to expedite bug fixes and features).

Additionally, I've found his ORCiD from https://f1000research.com/articles/8-139/v1: 0000-0003-2226-8692

@courtiol
Copy link
Contributor Author

This should be OK now!

@courtiol courtiol changed the title Fix two minor glitches Fix scaleGen example and use Authors@R Feb 22, 2020
@zkamvar
Copy link
Collaborator

zkamvar commented Feb 23, 2020

Looks good to me! Thank you for the contribution :)

@zkamvar zkamvar merged commit 95e1d68 into thibautjombart:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in doc spurious argument "met =" in examples scaleGen?
2 participants