Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap build_query to Query build #8

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Swap build_query to Query build #8

merged 2 commits into from
Aug 12, 2022

Conversation

tigohenryschultz
Copy link

No description provided.

SlickSolis added a commit to Slickdeals/paapi5-php-sdk that referenced this pull request Jul 13, 2022
@SlickSolis
Merged thewirecutter#8 via 3-way patch application
ab8a18b
@davidhirtz
Copy link

Would it be possible to merge this? :)

czzplnm and others added 2 commits August 12, 2022 10:53
@czzplnm @justinyost
Swap build_query to Query build
3a6ddc9
@justinyost
Updates Against Base Branch
296b99f 
And removes changes not directly related to updating to use Query::build.

Signed-off-by: Justin Yost <justin.yost@wirecutter.com>
@justinyost justinyost force-pushed the fix_build_query_deprecated branch from 90fbb53 to 296b99f Compare August 12, 2022 17:53
@justinyost
Copy link
Collaborator

@tigohenryschultz and @davidhirtz thanks, I rebased this against the primary branch with the updates from Amazon and removed anything not directly related to using Query::build. I'll then test the changes with the app we use this code in and merge these changes in.

justinyost
justinyost approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@justinyost justinyost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@justinyost justinyost merged commit 353a155 into thewirecutter:master Aug 12, 2022
justinyost added a commit that referenced this pull request Aug 16, 2022
@justinyost
Update the Version Number to 1.1.1
e0896f6 
1.1.1 Release
Swaps to Query::build #8
Supress Deprecated Function Notices #9

Signed-off-by: Justin Yost <justin.yost@wirecutter.com>
@justinyost justinyost mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyost justinyost justinyost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tigohenryschultz @davidhirtz @justinyost @czzplnm