Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "missing zh-TW.cutoff.time.one" error #9942

Closed
wants to merge 1 commit into from

Conversation

hanwu85
Copy link
Member

@hanwu85 hanwu85 commented Sep 11, 2024

"one" in the cutoff is missing in zh-TW.
I think this can fix the error.

one is missing in zh-TW.
I think this can fix the error.
Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why Internationalize (seemingly) didn't pick this up.
Do you have any clue, @jonatanklosko?

@jonatanklosko
Copy link
Member

If you look at other pluralization in the file, there's only "zero"/"other" in all cases.

According to rails-i18n (which internationalize uses as the reference) the forms should just be "other" (ref). Previously it was "one"/"other" and they changed 6 years ago. Internationalize always asks for "zero" in addition.

In other words, the current state is expected.

@gregorbg
Copy link
Member

Hm. If one is not being used at all, then why are you trying to add it? @hanwu85

@hanwu85
Copy link
Member Author

hanwu85 commented Sep 11, 2024

Because there is error whenever there is a 1 attempt to get < XXX in the cutoff
For example in thie compeititon.
So I thought one is being used on the website but does not exist in the Internationalize.

@jonatanklosko
Copy link
Member

jonatanklosko commented Sep 11, 2024

Looks like the JS i18n pluralization rules are not aligned with the ones we use in Rails. From the docs it looks like by default the rules match English, so we may need to register rules for other languages manually, perhaps using useMakePlural as suggested in the docs.

@gregorbg
Copy link
Member

Closing in favor of #9945

@gregorbg gregorbg closed this Sep 13, 2024
@hanwu85 hanwu85 deleted the patch-4 branch September 18, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants