Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain Competition Form fields to be edited after announcement #9770

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

gregorbg
Copy link
Member

@gregorbg gregorbg commented Aug 13, 2024

Basically works as intended per the field list WCAT sent to us.

In the backend, we have to give "normal" users (i.e. Delegates, Organizers) permissions to make these edits across the board. There is no (easy) way to restrict edits to only certain fields in the backend. Let's see which tests explode because of this assumption. EDIT: I used a hash_diff gem to easily compute what has been edited and then compare these edits against a list of allowed edits.

If anyone has any smart suggestions about the overrideEnabled name, I'm all ears.

@kr-matthews
Copy link
Contributor

If anyone has any smart suggestions about the overrideEnabled name, I'm all ears.

I'm not convinced that any of these are better, but how about forceEnabled, forceAllowEdits, or ignoreDisabled?

@gregorbg
Copy link
Member Author

@thewca-bot deploy staging

1 similar comment
@FinnIckler
Copy link
Member

@thewca-bot deploy staging

@gregorbg
Copy link
Member Author

@thewca-bot deploy staging

@gregorbg
Copy link
Member Author

gregorbg commented Oct 4, 2024

@thewca-bot deploy staging

1 similar comment
@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 9, 2024

@thewca-bot deploy staging

@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 9, 2024

Merged main in and redeploying because I want to check/announce the Registration countdown timer on staging

@gregorbg
Copy link
Member Author

gregorbg commented Oct 9, 2024

During your merge you pulled in a local Gemfile that has processor-specific hard dependencies installed. We need to revert that :P

@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 9, 2024

cry

@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 9, 2024

@thewca-bot deploy staging

@gregorbg gregorbg force-pushed the feature/wcat-edit-on-the-fly branch from d406664 to 6081e8e Compare October 9, 2024 07:25
@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 9, 2024

@thewca-bot deploy staging

@gregorbg gregorbg force-pushed the feature/wcat-edit-on-the-fly branch from 27fd1c7 to 630c77c Compare October 14, 2024 02:55
@gregorbg
Copy link
Member Author

@thewca-bot deploy staging

@gregorbg
Copy link
Member Author

@thewca-bot deploy staging

@FinnIckler
Copy link
Member

what's the hold up on this?

@gregorbg
Copy link
Member Author

gregorbg commented Dec 2, 2024

Testing. Right now (45 minutes ago from this comment) staging has been freshly deployed with a WRT PR to try and test, so we cannot deploy this at the same time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants