-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow certain Competition Form fields to be edited after announcement #9770
base: main
Are you sure you want to change the base?
Conversation
app/webpacker/components/CompetitionForm/FormSections/RegistrationDates.js
Outdated
Show resolved
Hide resolved
I'm not convinced that any of these are better, but how about |
@thewca-bot deploy staging |
1 similar comment
@thewca-bot deploy staging |
@thewca-bot deploy staging |
@thewca-bot deploy staging |
1 similar comment
@thewca-bot deploy staging |
Merged main in and redeploying because I want to check/announce the Registration countdown timer on staging |
During your merge you pulled in a local Gemfile that has processor-specific hard dependencies installed. We need to revert that :P |
cry |
@thewca-bot deploy staging |
d406664
to
6081e8e
Compare
@thewca-bot deploy staging |
27fd1c7
to
630c77c
Compare
@thewca-bot deploy staging |
@thewca-bot deploy staging |
what's the hold up on this? |
Testing. Right now (45 minutes ago from this comment) staging has been freshly deployed with a WRT PR to try and test, so we cannot deploy this at the same time |
Basically works as intended per the field list WCAT sent to us.
In the backend, we have to give "normal" users (i.e. Delegates, Organizers) permissions to make these edits across the board. There is no (easy) way to restrict edits to only certain fields in the backend. Let's see which tests explode because of this assumption.EDIT: I used ahash_diff
gem to easily compute what has been edited and then compare these edits against a list of allowed edits.If anyone has any smart suggestions about the
overrideEnabled
name, I'm all ears.