Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old admin panel #10645

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

danieljames-dj
Copy link
Member

The old panel is removed in this PR. The pages of the old admin panel are yet to be migrated to React, they will be done in upcoming PRs. This PR aims at disconnecting those pages from the panel and get an independent page to all of them.

Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is your point/intention with this PR? In terms of code, we're not gaining anything, and you might just as well "properly" migrate the pages to React one by one

@danieljames-dj
Copy link
Member Author

Just curious, what is your point/intention with this PR? In terms of code, we're not gaining anything, and you might just as well "properly" migrate the pages to React one by one

This PR is just to decouple everything from old admin panel and connect to new admin/WRT panel. I'm already working on the react migration in parallel - I started with 'run validators' page.

@danieljames-dj danieljames-dj merged commit 5a34c27 into thewca:main Jan 16, 2025
2 checks passed
@danieljames-dj danieljames-dj deleted the remove-old-admin-panel branch January 16, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants