Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPV6 address percent sign % device name [node patch needed ~ work aro… #279

Closed
wants to merge 1 commit into from

Conversation

MasterJames
Copy link

@MasterJames MasterJames commented Apr 14, 2017

…und]

The device name component is extracted temporarily and repaired after the parser runs.
I realize building it out manually is an option but this sense more fool proof.
Take it or leave it but it's there for others if they need or want to be assured IPV6 server to server routing with possible device names is available.
See #278

…und]

The device name component is extracted temporarily and repaired after the parser runs.
I realize building it out manually is an option but this sense more fool proof.
Take it or leave it but it's there for others if they need or want to be assured IPV6 server to server routing with possible device names is available.
@ibc
Copy link
Collaborator

ibc commented Apr 14, 2017

Given that this is not an issue to be fixed by WebSocket-Node, and given that the WebSocketClient.connect() API already allows passing a URL object (instead of a URL string) I don't think it's good to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants